-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22852/
-----------------------------------------------------------
(Updated June 25, 2014, 6:39 a.m.)
Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-1404
https://issues.apache.org/jira/browse/MESOS-1404
Repository: mesos-git
Description
-------
See summary. The main idea is to create a new binary called
'mesos-containerizer-helper' which performs most of the logic of 'execute' in
the original code.
Also, we leverage the new Subprocess interface to handle redirections.
(BTW: I fixed a few 70 char width comments issue when I doing the refactor).
Diffs (updated)
-----
src/Makefile.am 861aad2
src/slave/containerizer/launcher.hpp 835d7a9
src/slave/containerizer/launcher.cpp 2b13d1f
src/slave/containerizer/linux_launcher.hpp 622810c
src/slave/containerizer/linux_launcher.cpp 7ebccb4
src/slave/containerizer/mesos_containerizer.hpp 21affae
src/slave/containerizer/mesos_containerizer.cpp 76c101c
src/slave/containerizer/mesos_containerizer_helper.cpp PRE-CREATION
src/tests/isolator_tests.cpp 0bbec09
Diff: https://reviews.apache.org/r/22852/diff/
Testing
-------
make check
Thanks,
Jie Yu
