----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22852/#review46644 -----------------------------------------------------------
src/slave/containerizer/launcher.hpp <https://reviews.apache.org/r/22852/#comment82180> Thanks for cleaning up all the comment wrapping throughout!!! src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/22852/#comment82176> I thought we did os::su before we launched the preparation commands before. I'm happy to see it this way because I think those commands should be able to run with the same privileges as the mesos-slave (i.e., root), but just wanted to call out these semantics. src/slave/containerizer/mesos_containerizer_helper.cpp <https://reviews.apache.org/r/22852/#comment82178> Organizationally, I would have expected the subcommands to be declared here, not in mesos_containerizer.hpp. Then mesos_containerizer.cpp could include this header, which makes sense since mesos_containerizer.hpp is invoking mesos-containerizer-helper. Moreover, I would have s/MesosContainerizerLaunch/MesosContainerizerHelperLaunch/ to capture that this is a subcommand of mesos-containerizer-helper. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/22852/#comment82179> Thank you for the consistency cleanup throughout here!!! - Benjamin Hindman On June 25, 2014, 6:39 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22852/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 6:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1404 > https://issues.apache.org/jira/browse/MESOS-1404 > > > Repository: mesos-git > > > Description > ------- > > See summary. The main idea is to create a new binary called > 'mesos-containerizer-helper' which performs most of the logic of 'execute' in > the original code. > > Also, we leverage the new Subprocess interface to handle redirections. > > (BTW: I fixed a few 70 char width comments issue when I doing the refactor). > > > Diffs > ----- > > src/Makefile.am 861aad2 > src/slave/containerizer/launcher.hpp 835d7a9 > src/slave/containerizer/launcher.cpp 2b13d1f > src/slave/containerizer/linux_launcher.hpp 622810c > src/slave/containerizer/linux_launcher.cpp 7ebccb4 > src/slave/containerizer/mesos_containerizer.hpp 21affae > src/slave/containerizer/mesos_containerizer.cpp 76c101c > src/slave/containerizer/mesos_containerizer_helper.cpp PRE-CREATION > src/tests/isolator_tests.cpp 0bbec09 > > Diff: https://reviews.apache.org/r/22852/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
