----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22123/#review46725 -----------------------------------------------------------
Not sure if this review is still going anywhere, but I thought I'd put in my comments. include/mesos/mesos.proto <https://reviews.apache.org/r/22123/#comment82280> Please add some documentation to the FrameworkInfo comment that explains what a value of failover=true means and when it should be used. src/master/master.cpp <https://reviews.apache.org/r/22123/#comment82282> Moving this out of the while loop means that a framework without a failover_timeout will use the last valid failover_timeout, not the original default value. You should reinitialize failoverTimeout to the default value at the beginning of each iteration. src/master/master.cpp <https://reviews.apache.org/r/22123/#comment82281> Tabbing? - Adam B On June 1, 2014, 9:14 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22123/ > ----------------------------------------------------------- > > (Updated June 1, 2014, 9:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1118 > https://issues.apache.org/jira/browse/MESOS-1118 > > > Repository: mesos-git > > > Description > ------- > > I think the name of the boolean is a bit confusing, I could change it into > 'nofailover' which I think to be clearer. > > > Diffs > ----- > > include/mesos/mesos.proto 82388e1 > src/master/master.cpp 766a0e3 > > Diff: https://reviews.apache.org/r/22123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
