> On June 26, 2014, 8:39 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 128 > > <https://reviews.apache.org/r/22123/diff/1/?file=601126#file601126line128> > > > > Please add some documentation to the FrameworkInfo comment that > > explains what a value of failover=true means and when it should be used.
There is a comment about this on https://issues.apache.org/jira/browse/MESOS-1118, do you have something in mind ? - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22123/#review46725 ----------------------------------------------------------- On June 2, 2014, 4:14 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22123/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 4:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1118 > https://issues.apache.org/jira/browse/MESOS-1118 > > > Repository: mesos-git > > > Description > ------- > > I think the name of the boolean is a bit confusing, I could change it into > 'nofailover' which I think to be clearer. > > > Diffs > ----- > > include/mesos/mesos.proto 82388e1 > src/master/master.cpp 766a0e3 > > Diff: https://reviews.apache.org/r/22123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
