> On June 27, 2014, 4:08 a.m., Dominic Hamon wrote: > > src/master/master.hpp, line 373 > > <https://reviews.apache.org/r/22222/diff/4/?file=618541#file618541line373> > > > > i might be missing something, but why are these being stored in the > > master?
Yup, removed this for Isabel when I committed. > On June 27, 2014, 4:08 a.m., Dominic Hamon wrote: > > src/sasl/authenticator.hpp, line 476 > > <https://reviews.apache.org/r/22222/diff/4/?file=618543#file618543line476> > > > > should you check that a principal doesn't appear more than once? These are the same semantics as before, so this was left as is. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22222/#review46832 ----------------------------------------------------------- On June 26, 2014, 5:50 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22222/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 5:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1391 > https://issues.apache.org/jira/browse/MESOS-1391 > > > Repository: mesos-git > > > Description > ------- > > After Ben's comments, regroup of all types of authentication in one common > definition, this is a draft for this Issue, here are some questions: > > - Do I replace credentials flag completely or if this slight duplication will > suffice for now ? > - If I don't replace it, for now as it is in this patch, the flag is useless, > I should give it to the sasl/authenticator but I would really appreciate some > comments for that part. > > > Diffs > ----- > > include/mesos/mesos.proto 2f6be05 > src/Makefile.am b1b7d2d > src/credentials/credentials.hpp 98b9088 > src/master/flags.hpp 47bb0dc > src/master/master.hpp b56e9f4 > src/master/master.cpp dcf28ad > src/sasl/authenticator.hpp 365db5f > src/slave/flags.hpp 3b8ba08 > src/slave/slave.cpp ed3483f > src/tests/credentials_tests.cpp PRE-CREATION > src/tests/mesos.cpp 1037420 > > Diff: https://reviews.apache.org/r/22222/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
