----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22222/#review46041 -----------------------------------------------------------
Patch looks great! Reviews applied: [22222] All tests passed. - Mesos ReviewBot On June 17, 2014, 10:31 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22222/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 10:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1391 > https://issues.apache.org/jira/browse/MESOS-1391 > > > Repository: mesos-git > > > Description > ------- > > After Ben's comments, regroup of all types of authentication in one common > definition, this is a draft for this Issue, here are some questions: > > - Do I replace credentials flag completely or if this slight duplication will > suffice for now ? > - If I don't replace it, for now as it is in this patch, the flag is useless, > I should give it to the sasl/authenticator but I would really appreciate some > comments for that part. > > > Diffs > ----- > > include/mesos/mesos.proto 709b8b1 > src/Makefile.am 3e623cc > src/credentials/credentials.hpp 98b9088 > src/master/flags.hpp 780e219 > src/master/master.hpp 7a12185 > src/master/master.cpp 4a01b1a > src/sasl/authenticator.hpp 365db5f > src/slave/flags.hpp 3b8ba08 > src/slave/slave.hpp 3227e73 > src/slave/slave.cpp bc976b7 > src/tests/cluster.hpp 1c96ee7 > src/tests/credentials_tests.cpp PRE-CREATION > src/tests/mesos.hpp 0b9b2f9 > src/tests/mesos.cpp 98a7c38 > > Diff: https://reviews.apache.org/r/22222/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
