> On June 27, 2014, 4:04 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp, line 318 > > <https://reviews.apache.org/r/22825/diff/4/?file=618549#file618549line318> > > > > the option to ignore empty tokens might be useful for the future. maybe > > a TODO.
That's what strings::tokenize does, strings::split keeps the empty tokens. > On June 27, 2014, 4:04 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 163 > > <https://reviews.apache.org/r/22825/diff/4/?file=618548#file618548line163> > > > > why not just: > > > > if (n.isSome() && tokens.size() == n.get()) { > > break; > > } > > > > and remove _n and some. Great suggestion, did this for Isabel when I committed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22825/#review46831 ----------------------------------------------------------- On June 26, 2014, 5:49 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22825/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 5:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1522 > https://issues.apache.org/jira/browse/MESOS-1522 > > > Repository: mesos-git > > > Description > ------- > > SplitN function is stout/strings so we can choose how many tokens we want to > retreive > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 08428b8 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp c83156e > > Diff: https://reviews.apache.org/r/22825/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
