> On June 24, 2014, 10:14 a.m., Adam B wrote: > > Unit tests look good. My other concerns were not addressed though. > > Reiterating here.
Isabel moved all this into strings::split which is simpler and super clean so these issues no longer apply. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22825/#review46512 ----------------------------------------------------------- On June 26, 2014, 5:49 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22825/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 5:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff. > > > Bugs: MESOS-1522 > https://issues.apache.org/jira/browse/MESOS-1522 > > > Repository: mesos-git > > > Description > ------- > > SplitN function is stout/strings so we can choose how many tokens we want to > retreive > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 08428b8 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp c83156e > > Diff: https://reviews.apache.org/r/22825/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
