> On June 30, 2014, 10:08 p.m., Vinod Kone wrote: > > src/Makefile.am, line 955 > > <https://reviews.apache.org/r/22539/diff/9/?file=619384#file619384line955> > > > > All our example frameworks use libprocess. Did you add the "libprocess" > > suffix because you are planning to write other example frameworks that > > don't use libprocess? if not, kill that suffix.
There will be a pthread version with a new review thread. > On June 30, 2014, 10:08 p.m., Vinod Kone wrote: > > src/tests/examples_tests.cpp, line 27 > > <https://reviews.apache.org/r/22539/diff/9/?file=619386#file619386line27> > > > > s/Libprocess// Reserved for another pthread version. > On June 30, 2014, 10:08 p.m., Vinod Kone wrote: > > src/tests/examples_tests.cpp, line 28 > > <https://reviews.apache.org/r/22539/diff/9/?file=619386#file619386line28> > > > > s/libprocess// See above. > On June 30, 2014, 10:08 p.m., Vinod Kone wrote: > > src/examples/low_level_scheduler_libprocess.cpp, line 328 > > <https://reviews.apache.org/r/22539/diff/9/?file=619385#file619385line328> > > > > Can this be const? No, because we need a const version of scheduler::Mesos::send. - Zuyu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22539/#review47018 ----------------------------------------------------------- On June 27, 2014, 12:47 p.m., Zuyu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22539/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 12:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Add the low level scheduler example using libprocess > > > Diffs > ----- > > src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 > src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION > src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 > src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/22539/diff/ > > > Testing > ------- > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from ExamplesTest > [ RUN ] ExamplesTest.LowLevelSchedulerLibprocess > [ OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms) > [----------] 1 test from ExamplesTest (1670 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1684 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Zuyu Zhang > >
