----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23091/#review47692 -----------------------------------------------------------
Ship it! Looks great. Almost identical to the boost version, so it must be right. :) Did you test configure && make check with/without bundled picojson, with --enable_bundled=yes/no, and with/without system picojson installed? (or some relevant combination thereof?) 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/23091/#comment83843> tabbing? - Adam B On July 11, 2014, 9:17 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23091/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 9:17 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1173 > https://issues.apache.org/jira/browse/MESOS-1173 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against the system installed version of picojson. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 429c956 > 3rdparty/libprocess/configure.ac 27c6ede > src/Makefile.am 9027927 > > Diff: https://reviews.apache.org/r/23091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
