> On July 13, 2014, 8 a.m., Adam B wrote: > > Looks great. Almost identical to the boost version, so it must be right. :) > > Did you test configure && make check with/without bundled picojson, with > > --enable_bundled=yes/no, and with/without system picojson installed? (or > > some relevant combination thereof?)
Checked the following: default build (bundled) --without-bundled / --disable-bundled logic for both presence & absence of dependency. I kept the semantics for the prefixed installed versions --with-picojson=foo but I did not fully test a prefixed installation, I'm relying on the semantics from the other dependencies. > On July 13, 2014, 8 a.m., Adam B wrote: > > 3rdparty/libprocess/configure.ac, lines 81-85 > > <https://reviews.apache.org/r/23091/diff/1/?file=618982#file618982line81> > > > > tabbing? Yeah this is weird, the file is a mix. Opinions? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23091/#review47692 ----------------------------------------------------------- On July 11, 2014, 4:17 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23091/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 4:17 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1173 > https://issues.apache.org/jira/browse/MESOS-1173 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against the system installed version of picojson. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 429c956 > 3rdparty/libprocess/configure.ac 27c6ede > src/Makefile.am 9027927 > > Diff: https://reviews.apache.org/r/23091/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
