----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review47693 -----------------------------------------------------------
I'm concerned about these zookeeper-3.4.5/lib/* jars, and have a few other questions. src/Makefile.am <https://reviews.apache.org/r/22994/#comment83848> Shouldn't this be configurable? Set by --with-zookeeper=<path>? src/Makefile.am <https://reviews.apache.org/r/22994/#comment83845> Was this not needed for mesos_tests_CPPFLAGS before? Why is it needed now? src/examples/java/test-log.in <https://reviews.apache.org/r/22994/#comment83847> TestLog needs a ZK jar (and zk/lib/*) on its classpath. Instead of disabling the exit-on-error, I think we should try to get the correct ZOOKEEPER_JAR and ZOOKEEPER lib paths here. Please also run TestLog example for your testing. src/tests/zookeeper.cpp <https://reviews.apache.org/r/22994/#comment83846> What about "all the libraries in 'lib'"? zookeeper-3.4.5/lib/jline-0.9.94.jar zookeeper-3.4.5/lib/log4j-1.2.15.jar zookeeper-3.4.5/lib/netty-3.2.2.Final.jar zookeeper-3.4.5/lib/slf4j-api-1.6.1.jar zookeeper-3.4.5/lib/slf4j-log4j12-1.6.1.jar Seems like somebody wanted those. Are they not needed for the zk tests? Do these also need to get unbundled? Should we worry about version mismatches with the unbundled zk jar? - Adam B On July 11, 2014, 9:19 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22994/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 9:19 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Fixes for zookeeper tests when running --disable-bundled. > > There were issues with our zookeeper package so it was difficult to tease out > what was responsible. > > > Diffs > ----- > > src/Makefile.am 3c8b91a > src/examples/java/test-log.in 8afed0d > src/tests/zookeeper.cpp 29656eb > > Diff: https://reviews.apache.org/r/22994/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
