> On July 13, 2014, 8:35 a.m., Adam B wrote: > > src/Makefile.am, line 1074 > > <https://reviews.apache.org/r/22994/diff/2/?file=618603#file618603line1074> > > > > Was this not needed for mesos_tests_CPPFLAGS before? Why is it needed > > now?
B4 the tests files actually reconstructed the 3rdparty path in the code. > On July 13, 2014, 8:35 a.m., Adam B wrote: > > src/examples/java/test-log.in, lines 22-28 > > <https://reviews.apache.org/r/22994/diff/2/?file=618604#file618604line22> > > > > TestLog needs a ZK jar (and zk/lib/*) on its classpath. Instead of > > disabling the exit-on-error, I think we should try to get the correct > > ZOOKEEPER_JAR and ZOOKEEPER lib paths here. > > Please also run TestLog example for your testing. So I didn't want to change all the exception logic for the --disable-bundled case. I admit, we should probably be more through here. > On July 13, 2014, 8:35 a.m., Adam B wrote: > > src/tests/zookeeper.cpp, lines 66-69 > > <https://reviews.apache.org/r/22994/diff/2/?file=618605#file618605line66> > > > > What about "all the libraries in 'lib'"? > > zookeeper-3.4.5/lib/jline-0.9.94.jar > > zookeeper-3.4.5/lib/log4j-1.2.15.jar > > zookeeper-3.4.5/lib/netty-3.2.2.Final.jar > > zookeeper-3.4.5/lib/slf4j-api-1.6.1.jar > > zookeeper-3.4.5/lib/slf4j-log4j12-1.6.1.jar > > Seems like somebody wanted those. Are they not needed for the zk tests? > > Do these also need to get unbundled? Should we worry about version > > mismatches with the unbundled zk jar? This is where distro policy meets rebundle-java-universe. By constraints, distros will never have a zk.jar without the dep-graph. Perhaps overloading a check with a -DBUNDLED is cleaner here? > On July 13, 2014, 8:35 a.m., Adam B wrote: > > src/Makefile.am, line 45 > > <https://reviews.apache.org/r/22994/diff/2/?file=618603#file618603line45> > > > > Shouldn't this be configurable? Set by --with-zookeeper=<path>? Yeah, this should be converted. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review47693 ----------------------------------------------------------- On July 11, 2014, 4:19 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22994/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 4:19 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1168 > https://issues.apache.org/jira/browse/MESOS-1168 > > > Repository: mesos-git > > > Description > ------- > > Fixes for zookeeper tests when running --disable-bundled. > > There were issues with our zookeeper package so it was difficult to tease out > what was responsible. > > > Diffs > ----- > > src/Makefile.am 3c8b91a > src/examples/java/test-log.in 8afed0d > src/tests/zookeeper.cpp 29656eb > > Diff: https://reviews.apache.org/r/22994/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
