----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/#review47842 -----------------------------------------------------------
Vinod help me setup a CI job running the health check tests with this fix and it has been passing over 3 times so far (https://builds.apache.org/view/All/job/mesos-tnachen/) I think it should be good to re-enable again, let me know if anyone thinks different! - Timothy Chen On July 15, 2014, 8:34 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23443/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 8:34 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-1533 > https://issues.apache.org/jira/browse/MESOS-1533 > > > Repository: mesos-git > > > Description > ------- > > Currently the health check tests are disabled as it was flaky. Part of the > reason is that all assertions was EXPECTs instead of ASSERTs so it will > continue to execute. > Another issue was it's currently discovering the path to launch health check > executable from the command executor main argv[0] path. > However, the correct path is to launch the generated script that does library > path resolution, which is the parent of .libs. > > > Diffs > ----- > > src/launcher/executor.cpp a573637 > src/tests/health_check_tests.cpp 44711fd > > Diff: https://reviews.apache.org/r/23443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
