> On July 16, 2014, 4:04 p.m., Benjamin Hindman wrote: > > src/tests/health_check_tests.cpp, line 79 > > <https://reviews.apache.org/r/23443/diff/4/?file=632794#file632794line79> > > > > Please add a newline above and a comment that explains why we need to > > do this and why we're calling this MESOS_LAUNCHER_DIR. In fact, I was > > expecting the slave to always set this environment variable (like your old > > patch did originally), but I think this is fine for now. Also, minor nit: > > s/Environment_Variable* var/Environment::Variable* variable/. Thanks Tim!
Sounds good, I just reverted the EXPECT ASSERT changes and addressed your comment. The tests has been passing all night so far. Thanks! - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23443/#review47891 ----------------------------------------------------------- On July 16, 2014, 5:30 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23443/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 5:30 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-1533 > https://issues.apache.org/jira/browse/MESOS-1533 > > > Repository: mesos-git > > > Description > ------- > > Currently the health check tests are disabled as it was flaky. Part of the > reason is that all assertions was EXPECTs instead of ASSERTs so it will > continue to execute. > Another issue was it's currently discovering the path to launch health check > executable from the command executor main argv[0] path. > However, the correct path is to launch the generated script that does library > path resolution, which is the parent of .libs. > > > Diffs > ----- > > src/launcher/executor.cpp a573637 > src/tests/health_check_tests.cpp 44711fd > > Diff: https://reviews.apache.org/r/23443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
