----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20504/#review47913 -----------------------------------------------------------
Ship it! Are you considering renaming process::post to process::inject::message? 3rdparty/libprocess/include/process/process.hpp <https://reviews.apache.org/r/20504/#comment84144> I think we would normally have newlines at the top and bottom of the namespace. 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/20504/#comment84148> Would be nice if all of these tests used Futures instead of volatile booleans, because they have the proper memory barriers in place no matter how you use them and we could avoid the while(true) loop here with AWAIT_READY(). But since this is just copy/paste, looks good for now! - Ben Mahler On July 15, 2014, 12:36 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20504/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 12:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1059 > https://issues.apache.org/jira/browse/MESOS-1059 > > > Repository: mesos-git > > > Description > ------- > > This is used in the subsequent review. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 3c31dfbaef327d1945cd8ee3743c31c2850d467d > 3rdparty/libprocess/src/process.cpp > 0c0fca7acf870fdc7ca89d471cbff63af7799eef > 3rdparty/libprocess/src/tests/process_tests.cpp > ebce48c56eba06c00cf83c48b7934b4a8e648269 > > Diff: https://reviews.apache.org/r/20504/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
