> On July 16, 2014, 6:12 p.m., Ben Mahler wrote: > > Are you considering renaming process::post to process::inject::message?
i could, but "post" is used outside tests in log/network.hpp. > On July 16, 2014, 6:12 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/process.hpp, lines 402-404 > > <https://reviews.apache.org/r/20504/diff/3/?file=630337#file630337line402> > > > > I think we would normally have newlines at the top and bottom of the > > namespace. I don't think so. For example, look at master.hpp and slave.hpp. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20504/#review47913 ----------------------------------------------------------- On July 15, 2014, 12:36 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20504/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 12:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1059 > https://issues.apache.org/jira/browse/MESOS-1059 > > > Repository: mesos-git > > > Description > ------- > > This is used in the subsequent review. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 3c31dfbaef327d1945cd8ee3743c31c2850d467d > 3rdparty/libprocess/src/process.cpp > 0c0fca7acf870fdc7ca89d471cbff63af7799eef > 3rdparty/libprocess/src/tests/process_tests.cpp > ebce48c56eba06c00cf83c48b7934b4a8e648269 > > Diff: https://reviews.apache.org/r/20504/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
