-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23599/#review47993
-----------------------------------------------------------
Bad patch!
Reviews applied: [23599]
Failed command: ./support/mesos-style.py
Error:
Checking 490 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/master/constants.hpp:99: Namespace should be terminated with "// namespace
master {" [readability/namespace] [5]
src/master/constants.hpp:101: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/master/constants.cpp:45: Namespace should be terminated with "// namespace
master {" [readability/namespace] [5]
src/master/constants.cpp:47: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/master/repairer.cpp:44: Namespace should be terminated with "// namespace
master {" [readability/namespace] [5]
src/master/repairer.cpp:46: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/master/master.cpp:1430: Missing username in TODO; it should look like "//
TODO(my_username): Stuff." [readability/todo] [2]
src/master/flags.hpp:316: Namespace should be terminated with "// namespace
master {" [readability/namespace] [5]
src/master/flags.hpp:318: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/examples/utils.hpp:43: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/slave/flags.hpp:341: Namespace should be terminated with "// namespace
slave {" [readability/namespace] [5]
src/slave/flags.hpp:343: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/slave/gc.cpp:209: Namespace should be terminated with "// namespace slave
{" [readability/namespace] [5]
src/slave/gc.cpp:211: Namespace should be terminated with "// namespace mesos
{" [readability/namespace] [5]
src/slave/gc.hpp:131: Namespace should be terminated with "// namespace slave
{" [readability/namespace] [5]
src/slave/gc.hpp:133: Namespace should be terminated with "// namespace mesos
{" [readability/namespace] [5]
src/slave/slave.cpp:882: Missing username in TODO; it should look like "//
TODO(my_username): Stuff." [readability/todo] [2]
src/sched/sched.cpp:1292: Missing username in TODO; it should look like "//
TODO(my_username): Stuff." [readability/todo] [2]
src/common/type_utils.hpp:457: Namespace should be terminated with "//
namespace internal {" [readability/namespace] [5]
src/common/type_utils.hpp:457: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/common/type_utils.hpp:481: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/common/factory.hpp:117: Namespace should be terminated with "// namespace
factory {" [readability/namespace] [5]
src/common/factory.hpp:117: Namespace should be terminated with "// namespace
internal {" [readability/namespace] [5]
src/common/factory.hpp:117: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/common/protobuf_utils.hpp:120: Namespace should be terminated with "//
namespace protobuf {" [readability/namespace] [5]
src/common/values.cpp:195: Namespace should be terminated with "// namespace
ranges {" [readability/namespace] [5]
src/common/values.cpp:592: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
src/common/status_utils.hpp:44: Namespace should be terminated with "//
namespace status {" [readability/namespace] [5]
src/common/status_utils.hpp:45: Namespace should be terminated with "//
namespace internal {" [readability/namespace] [5]
src/common/status_utils.hpp:46: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/common/date_utils.hpp:54: Namespace should be terminated with "//
namespace internal {" [readability/namespace] [5]
src/common/date_utils.hpp:54: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/python/native/mesos_scheduler_driver_impl.hpp:122: Namespace should be
terminated with "// namespace python {" [readability/namespace] [5]
src/python/native/mesos_scheduler_driver_impl.hpp:122: Namespace should be
terminated with "// namespace mesos {" [readability/namespace] [5]
src/python/native/module.hpp:135: Namespace should be terminated with "//
namespace python {" [readability/namespace] [5]
src/python/native/module.hpp:135: Namespace should be terminated with "//
namespace mesos {" [readability/namespace] [5]
src/python/native/mesos_executor_driver_impl.hpp:102: Namespace should be
terminated with "// namespace python {" [readability/namespace] [5]
src/python/native/mesos_executor_driver_impl.hpp:102: Namespace should be
terminated with "// namespace mesos {" [readability/namespace] [5]
src/python/native/module.cpp:70: Namespace should be terminated with "//
namespace {" [readability/namespace] [5]
src/python/native/mesos_executor_driver_impl.cpp:348: Namespace should be
terminated with "// namespace python {" [readability/namespace] [5]
src/python/native/mesos_executor_driver_impl.cpp:348: Namespace should be
terminated with "// namespace mesos {" [readability/namespace] [5]
src/exec/exec.cpp:472: Missing username in TODO; it should look like "//
TODO(my_username): Stuff." [readability/todo] [2]
src/linux/cgroups.cpp:1063: Namespace should be terminated with "// namespace
internal {" [readability/namespace] [5]
src/linux/cgroups.cpp:1688: Namespace should be terminated with "// namespace
{" [readability/namespace] [5]
src/linux/routing/route.cpp:139: Namespace should be terminated with "//
namespace route {" [readability/namespace] [5]
src/linux/routing/route.cpp:140: Namespace should be terminated with "//
namespace routing {" [readability/namespace] [5]
src/linux/routing/route.hpp:62: Namespace should be terminated with "//
namespace route {" [readability/namespace] [5]
src/linux/routing/route.hpp:63: Namespace should be terminated with "//
namespace routing {" [readability/namespace] [5]
src/linux/routing/link/link.hpp:116: Namespace should be terminated with "//
namespace link {" [readability/namespace] [5]
src/linux/routing/link/link.hpp:117: Namespace should be terminated with "//
namespace routing {" [readability/namespace] [5]
include/mesos/values.hpp:64: Namespace should be terminated with "// namespace
values {" [readability/namespace] [5]
include/mesos/values.hpp:65: Namespace should be terminated with "// namespace
internal {" [readability/namespace] [5]
include/mesos/values.hpp:67: Namespace should be terminated with "// namespace
mesos {" [readability/namespace] [5]
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp:311: Namespace
should be terminated with "// namespace strings {" [readability/namespace] [5]
3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp:35: Namespace
should be terminated with "// namespace tuples {" [readability/namespace] [5]
3rdparty/libprocess/include/process/event.hpp:203: Namespace should be
terminated with "// namespace process {" [readability/namespace] [5]
3rdparty/libprocess/include/process/protobuf.hpp:75: Namespace should be
terminated with "// namespace protobuf {" [readability/namespace] [5]
3rdparty/libprocess/include/process/protobuf.hpp:75: Namespace should be
terminated with "// namespace google {" [readability/namespace] [5]
3rdparty/libprocess/include/process/metrics/timer.hpp:116: Namespace should be
terminated with "// namespace metrics {" [readability/namespace] [5]
3rdparty/libprocess/include/process/metrics/timer.hpp:117: Namespace should be
terminated with "// namespace process {" [readability/namespace] [5]
3rdparty/libprocess/include/process/tuples/tuples.hpp:152: Namespace should be
terminated with "// namespace tuples {" [readability/namespace] [5]
3rdparty/libprocess/include/process/tuples/tuples.hpp:152: Namespace should be
terminated with "// namespace process {" [readability/namespace] [5]
3rdparty/libprocess/src/decoder.hpp:21: Missing username in TODO; it should
look like "// TODO(my_username): Stuff." [readability/todo] [2]
3rdparty/libprocess/src/process.cpp:4076: Namespace should be terminated with
"// namespace internal {" [readability/namespace] [5]
Total errors found: 64
- Mesos ReviewBot
On July 17, 2014, 1:24 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23599/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:24 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enable todo and namespace rules in style check
>
> Modified cpplint.py to support
> } // namespace foo {
> instead of
> } // namespace foo
>
>
> Diffs
> -----
>
> support/cpplint.patch 4f1ec668822b3ea3d8bfb12d7d41408ccaa42271
> support/cpplint.py 90aa4ba648ce83f84ec62d96e26eba5e7f11f30c
> support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084
>
> Diff: https://reviews.apache.org/r/23599/diff/
>
>
> Testing
> -------
>
> make check and style check
>
>
> Thanks,
>
> Timothy Chen
>
>
