----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23599/#review49069 -----------------------------------------------------------
Ship it! Thanks a lot Tim! The committer (me?) can make the tiny alphabetizing change I suggested. support/mesos-style.py <https://reviews.apache.org/r/23599/#comment85896> Alphabetize, please. - Adam B On July 19, 2014, 1:50 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23599/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 1:50 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Enable todo and namespace rules in style check > > Modified cpplint.py to support > } // namespace foo { > instead of > } // namespace foo > > > Diffs > ----- > > support/cpplint.patch 4f1ec668822b3ea3d8bfb12d7d41408ccaa42271 > support/cpplint.py 90aa4ba648ce83f84ec62d96e26eba5e7f11f30c > support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084 > > Diff: https://reviews.apache.org/r/23599/diff/ > > > Testing > ------- > > make check and style check > > > Thanks, > > Timothy Chen > >
