> On July 17, 2014, 9:29 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4221 > > <https://reviews.apache.org/r/23661/diff/1/?file=634633#file634633line4221> > > > > How about > > > > "Sending status update " << update << " as the slave " << > > slaveInfo.id() << " (" << slaveInfo.hostname() << ") is removed";
I've now updated all the status updates to use forward(), which means all the status update logging is consistently formatted. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48063 ----------------------------------------------------------- On July 17, 2014, 11:49 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23661/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 11:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > All status updates in the master are now sent via Master::forward() which > means they are all logged in the same format. > > This should make debugging easier and it simplifies the Master code. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 12ff00a2e1262d785dbd6ec4d54e50d88d611e20 > src/master/master.hpp fa46a67fba0fc0a019cdb37770994eee0099d260 > src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea > > Diff: https://reviews.apache.org/r/23661/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
