> On July 18, 2014, 6:06 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 3150 > > <https://reviews.apache.org/r/23661/diff/3/?file=634948#file634948line3150> > > > > Why not just pass the framework pid instead of Framework*?
I was a bit worried about the type signature: forward(StatusUpdate, UPID, UPID); vs. forward(StatusUpdate, UPID, Framework*); My thinking was: (1) The latter forces a Framework lookup in the caller, which they need to do anyway to get the UPID. (2) The latter is less error-prone. With the former, one can accidentally pass the UPIDs in the wrong order. It's hard to read a call-site and know if it's correct, without referring to the argument names. What do you think? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23661/#review48147 ----------------------------------------------------------- On July 18, 2014, 1:51 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23661/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 1:51 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > All status updates in the master are now sent via Master::forward() which > means they are all logged in the same format. > > This should make debugging easier and it simplifies the Master code. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 12ff00a2e1262d785dbd6ec4d54e50d88d611e20 > src/master/master.hpp fa46a67fba0fc0a019cdb37770994eee0099d260 > src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea > > Diff: https://reviews.apache.org/r/23661/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
