-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23713/#review48275
-----------------------------------------------------------



support/verify-reviews.py
<https://reviews.apache.org/r/23713/#comment84682>

    is the big change to verify reviews to address this TODO?
    
    if yes, why not simply do what the git precommit hook does?
    
    shell("git diff --cached --name-only --diff-filter=AM | xargs 
./support/mesos-style.py")
    
    would that work?


- Vinod Kone


On July 19, 2014, 9:35 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23713/
> -----------------------------------------------------------
> 
> (Updated July 19, 2014, 9:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> mesos-style by default checks only changed files
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084 
>   support/verify-reviews.py 9408747995db4b78ac6edd74995a05ab0355f1df 
> 
> Diff: https://reviews.apache.org/r/23713/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to