> On July 21, 2014, 7:37 p.m., Vinod Kone wrote: > > support/verify-reviews.py, line 113 > > <https://reviews.apache.org/r/23713/diff/1/?file=636337#file636337line113> > > > > is the big change to verify reviews to address this TODO? > > > > if yes, why not simply do what the git precommit hook does? > > > > shell("git diff --cached --name-only --diff-filter=AM | xargs > > ./support/mesos-style.py") > > > > would that work?
Ah, I originally wanted to just speed up mesos-style as the script takes a longer now with the new styles I added. What you have these should just work as well, just discard this review then. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23713/#review48275 ----------------------------------------------------------- On July 19, 2014, 9:35 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23713/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 9:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > mesos-style by default checks only changed files > > > Diffs > ----- > > support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084 > support/verify-reviews.py 9408747995db4b78ac6edd74995a05ab0355f1df > > Diff: https://reviews.apache.org/r/23713/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
