-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/
-----------------------------------------------------------
(Updated July 29, 2014, 2:33 p.m.)
Review request for mesos, Adam B and Ben Mahler.
Changes
-------
1. todo meets the standard
2. added todo to all places to be refactored
3. added more error information for bad file read
4. added checking for the zk url from the file
5. url parse happens only once
Bugs: MESOS-1635
https://issues.apache.org/jira/browse/MESOS-1635
Repository: mesos-git
Description
-------
Fixes MESOS-1635 "zk flag fails when specifying a file and the replicated logs"
replaced the current TODO with code :) The code is consistent with similar
types of checks elsewhere in code.
Diffs (updated)
-----
src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
src/master/detector.cpp a34cc211941972e2d64802d5c7ed3f5026229744
src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a
Diff: https://reviews.apache.org/r/23997/diff/
Testing
-------
The code change is simple and no unit test is provided. It compiles, passes
style check and is functional via manual check.
Thanks,
Ken Sipe
