----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49664 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/24343/#comment86920> is there a reason this is a nested class in Master? src/master/master.hpp <https://reviews.apache.org/r/24343/#comment86921> might be worth adding the capacity to the error message to make it easier to debug issues. src/master/master.cpp <https://reviews.apache.org/r/24343/#comment86922> please pull these out into more traditional if statements above the 'put' call. this is completely unreadable. src/master/master.cpp <https://reviews.apache.org/r/24343/#comment86923> assuming there might be more errors in the future, this comment might be misleading. src/master/master.cpp <https://reviews.apache.org/r/24343/#comment86924> maybe a const Option<string>& here? src/master/master.cpp <https://reviews.apache.org/r/24343/#comment86925> consider including the number of messages and principal. - Dominic Hamon On Aug. 5, 2014, 4:41 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24343/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 4:41 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >
