----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49699 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/24343/#comment86996> It also returns error when the rate limiter reachs its capacity too right? src/master/master.hpp <https://reviews.apache.org/r/24343/#comment86988> Nit: Seems like it's used just as a queue, why not just use queue? src/master/master.cpp <https://reviews.apache.org/r/24343/#comment86992> I wonder if we should rename __visit to something like dropMessage or failed that it's obvious it's the failed throttle/limiter path. src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/24343/#comment86993> I think you can bring it back one line: error(driver, "Message dropped: Reached capacity: 2") - Timothy Chen On Aug. 6, 2014, 5:53 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24343/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 5:53 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >
