----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24356/#review49700 -----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/24356/#comment86989> In what order are you iterating through the slaves? What order should it be? src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/24356/#comment86990> Why even have an 'allocatedResources' variable if it's always the same as 'unreserved'? - Adam B On Aug. 5, 2014, 5:49 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24356/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 5:49 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1119 > https://issues.apache.org/jira/browse/MESOS-1119 > > > Repository: mesos-git > > > Description > ------- > > The allocator now updates the DRF algorithm after every allocation of a > slave's resources. This will make the allocation more granular and fair. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 35d1579bbd665dfdd238932902ae16880dadeb66 > src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7 > > Diff: https://reviews.apache.org/r/24356/diff/ > > > Testing > ------- > > make check > > make check GTEST_FILTER="*PerSlaveAllocation*" GTEST_REPEAT=1000 > GTEST_BREAK_ON_FAILURE=1 GTEST_VERBOSE=1 MESOS_VERBOSE=1 GLOG_v=1 > > > Thanks, > > Vinod Kone > >
