----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24356/#review49901 -----------------------------------------------------------
Have you done any simulations or performance tests on a test cluster? I'd love to see some numbers that prove that this is more fair in some scenario than the previous algorithm. Not sure I can blindly trust a unit test. - Adam B On Aug. 6, 2014, 3:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24356/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 3:56 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1119 > https://issues.apache.org/jira/browse/MESOS-1119 > > > Repository: mesos-git > > > Description > ------- > > The allocator now updates the DRF algorithm after every allocation of a > slave's resources. This will make the allocation more granular and fair. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > c7e689e882e88ef5adb31e72909ef85d8a8c0067 > src/tests/allocator_tests.cpp f0226cb3fa4b54f917c0a0f59b986e9115352507 > > Diff: https://reviews.apache.org/r/24356/diff/ > > > Testing > ------- > > make check > > make check GTEST_FILTER="*PerSlaveAllocation*" GTEST_REPEAT=1000 > GTEST_BREAK_ON_FAILURE=1 GTEST_VERBOSE=1 MESOS_VERBOSE=1 GLOG_v=1 > > > Thanks, > > Vinod Kone > >
