> On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote: > > why not follow the prefix pattern if it's in a non-standard location > > --with-curl=/my/custom/path?
I have no problem with that suggestion. I've created a new patch which adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it be OK to attach the patch to this review, or is it better to close this out and submit again? - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/#review50057 ----------------------------------------------------------- On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24407/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 7:37 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Repository: mesos-git > > > Description > ------- > > If libcurl.a is located on a non-standard path, the test for libcurl in the > configure script fails, even if the path is specified in LDFLAGS. > > To work around this we can use curl-config to provide the needed path and > link options to the compiler. > > This patch modifies configure.ac to check for curl-config and use its output > as an argument to AC_CHECK_LIB if possible. > > > Diffs > ----- > > configure.ac a9cc6df > > Diff: https://reviews.apache.org/r/24407/diff/ > > > Testing > ------- > > Tested this on Ubuntu 12.04 against master with libcurl in a path not > included in LDFLAGS. > > > Thanks, > > Chris Heller > >
