-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407/#review50460
-----------------------------------------------------------
The option description needs to be added e.g. -
AC_ARG_WITH([glog],
AS_HELP_STRING([--with-glog@<:@=DIR@:>@],
[excludes building and using the bundled glog
package in lieu of an installed version at a
location prefixed by the given path]),
[without_bundled_glog=yes], [])
Also, you can update the patch via "Update->Update Diff"
- Timothy St. Clair
On Aug. 11, 2014, 7:28 p.m., Chris Heller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24407/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 7:28 p.m.)
>
>
> Review request for mesos and Timothy St. Clair.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If libcurl.a is located on a non-standard path, the test for libcurl in the
> configure script fails, even if the path is specified in LDFLAGS.
>
> To work around this we can use curl-config to provide the needed path and
> link options to the compiler.
>
> This patch modifies configure.ac to check for curl-config and use its output
> as an argument to AC_CHECK_LIB if possible.
>
>
> Diffs
> -----
>
> configure.ac a9cc6df
>
> Diff: https://reviews.apache.org/r/24407/diff/
>
>
> Testing
> -------
>
> Tested this on Ubuntu 12.04 against master with libcurl in a path not
> included in LDFLAGS.
>
>
> File Attachments
> ----------------
>
> Add --with-curl, --with-sasl2, --with-zlib to configure
>
> https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1__0000_configure_with_libs.patch
>
>
> Thanks,
>
> Chris Heller
>
>
