> On June 23, 2014, 6:50 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1185 > > <https://reviews.apache.org/r/22313/diff/11/?file=612826#file612826line1185> > > > > Also, what about launching the tasks after updating resources in > > registerExecutor()? > > Yifan Gu wrote: > Sounds good, Should I do it in this patch or open a new JIRA? > > Vinod Kone wrote: > this one is fine. in fact i would prefer to registerExecutor() one first > because that is going to affect all executors. the one in launchTask() when > executor is RUNNING can be done latter (maybe in a subsequent patch) because > that only affects executors that have multiple tasks. > > Yifan Gu wrote: > Ok. Will do, I just reverted this patch. > > Yifan Gu wrote: > And I found we need to do this too in reregisterExecutor()... > > Vinod Kone wrote: > What did you revert? I still see container update() being called in > runTask(). > > Yifan Gu wrote: > Sorry for confusion. By 'revert' I mean now, I don't put the executor in > pending anymore, and I do a check on NULL framework and NULL executor as > before. > I haven't done the (re)registerExecutor() stuff. Will try to do it > tomorrow. > > But still, I will need some review on this one, since the approach on > (re)registerExecutor will almost be the same as this one. > Thanks Vinod! > > Vinod Kone wrote: > OK. Can you resolve or drop (with comments) the issues that were raised?
Can you add a TODO and open a ticket to track this? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review46429 ----------------------------------------------------------- On Aug. 6, 2014, 1:11 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 1:11 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp c12cd0a > src/slave/slave.cpp c56cac8 > src/tests/slave_tests.cpp 3a7fee6 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate > SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved > SlaveTest.LaunchTaskAfterContainerizerUpdate > > ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure > --gtest_filter=*LaunchTask* > > successful times > 2000 > > make check > > > File Attachments > ---------------- > > framework will exit > > https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff > log > > https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log > > > Thanks, > > Yifan Gu > >
