> On Aug. 11, 2014, 10:46 p.m., Jie Yu wrote: > > src/slave/containerizer/docker.cpp, line 446 > > <https://reviews.apache.org/r/24464/diff/10/?file=657551#file657551line446> > > > > You probably want to do a 'logs.wait()' here: > > > > logs.wait() > > .onAny(defer(self(), &Self::__logging, ...); > > > > Inside __logging, you can add some logging.
I don't want to block on wait here since I want to launch the command executor right away afterwards. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50206 ----------------------------------------------------------- On Aug. 11, 2014, 8:19 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 8:19 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24464 > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > src/tests/docker_containerizer_tests.cpp > a559836dd11a9a97e5939364c4b35a8dbb6a503d > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
