----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50134 -----------------------------------------------------------
src/docker/docker.hpp <https://reviews.apache.org/r/24464/#comment87716> Hum, this interface is weird to me. What if in the future we switch to use the REST api, what does the return value mean? Ideally, docker.logs should return a 'stream' object, something like this: class Docker { class LogStream { int out(); // return the out pipe. int err(); // return the err pipe. void close(); // terminate the subprocess. ... }; Future<LogStream> logs(const string& containerName); }; docker.logs(containerName).then(lambda::bind(&_logs, lambda::_1); void _logs(const Docker::LogStream& stream) { io::redirect(stream.out(), "stdout"); io::redirect(stream.err(), "stderr"); } src/docker/docker.cpp <https://reviews.apache.org/r/24464/#comment87717> Looks like these changes are not necessary given your recent changes? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/24464/#comment87718> Can you expand here: what extra log will be there if you run the above command: /bin/sh -c 'echo out!; echo err! 1>&2' - Jie Yu On Aug. 10, 2014, 6:51 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24464/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 6:51 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24464 > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c > src/tests/docker_containerizer_tests.cpp > a559836dd11a9a97e5939364c4b35a8dbb6a503d > > Diff: https://reviews.apache.org/r/24464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
