----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review52485 -----------------------------------------------------------
Ship it! Thanks Kapil! Will commit this shortly. I made a few minor comments that I will take care of before committing. src/master/master.cpp <https://reviews.apache.org/r/22066/#comment91279> Let's move this above the ephemeral port stripping so that the two maps 'offers' and 'offerTimers' are manipulated close to one another. src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91282> We can capture the offers themselves to ensure that we're being re-offered the same amount of resources. src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91289> Would be nice to add a comment here reflecting that the allocation interval is why we needed to resume the clock. src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91285> I think we can remove this test, since the resource offer / rescind mechanics with no offer timeout is exercised by most of the integration tests, and the mock scheduler will complain should there be any unexpected calls (e.g. rescind). src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91290> Have you run the tests lately? This test fails because the slave is expecting to hear back from the master within 75 seconds, otherwise it re-registers. At that point, the master rescinds the offers. I'll update these tests to use a 30 second timeout for now. src/tests/master_tests.cpp <https://reviews.apache.org/r/22066/#comment91286> "rescinded" - Ben Mahler On Sept. 4, 2014, 9:09 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22066/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 9:09 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy > Chen. > > > Bugs: mesos-186 > https://issues.apache.org/jira/browse/mesos-186 > > > Repository: mesos-git > > > Description > ------- > > A timer is associated with each newly created offer. > The offer is rescinded on timeout. > The timer is disarmed on a launchTask or decline. > > This is continuation of Tim's patch: https://reviews.apache.org/r/22796/. > Revision two represents the latest patch from Tim. I have tried to address > the comments/concerns from that request into the third revision. > > > Diffs > ----- > > src/master/flags.hpp 5e9ecb5 > src/master/master.hpp c9f989a > src/master/master.cpp 2508b38 > src/tests/master_tests.cpp eaa1675 > > Diff: https://reviews.apache.org/r/22066/diff/ > > > Testing > ------- > > Added one more test after Tim's patch to test offer is not rescinded once it > has been declined. > > make check > > > Thanks, > > Kapil Arya > >
