----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/#review50393 -----------------------------------------------------------
Could you include more information in the summary about the motivation? :) For API changes so close to a cut, we should probably have a few eyes on it too. This has come up before, be sure to take a look at the approach by Jason here: https://reviews.apache.org/r/15542/ Notably, the path and arguments were split apart, in a similar manner to how execv works. We also didn't need the boolean as you have in your patch here. Curious to hear your thoughts on that. - Ben Mahler On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24619/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 11:21 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto cc9f20e > > Diff: https://reviews.apache.org/r/24619/diff/ > > > Testing > ------- > > > Thanks, > > Jie Yu > >
