----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/#review50476 -----------------------------------------------------------
A few notes since we're going to cut 0.20.0 and this is an API change! include/mesos/mesos.proto <https://reviews.apache.org/r/24619/#comment88282> It's not clear why we need the boolean 'shell', since the non-emptiness of 'argv' should indicate a preference to use that over 'value'. If there's some reason we need the boolean (e.g. Docker implementation leaking in here) we should add a small note. Is it possible to have an empty 'argv'? Curious, is a boolean enough or do you want a Type enum here? Is it true that we'll be using 'execve'? Seems like we just might want to outline the two styles of running commands taking inspiration from Subprocess: https://docs.python.org/2/library/subprocess.html#subprocess.Popen include/mesos/mesos.proto <https://reviews.apache.org/r/24619/#comment88290> s/argv/arguments/ 'argv' seems to be a historical name coming from the c 'argc' (count) 'argv' (vector) argument passing technique. Seems like we should avoid it by just calling this "arguments" since we avoid abbreviations as well. Maybe a small example to indicate that the program name is expected to be included here. - Ben Mahler On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24619/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 11:21 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto cc9f20e > > Diff: https://reviews.apache.org/r/24619/diff/ > > > Testing > ------- > > > Thanks, > > Jie Yu > >
