----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50590 -----------------------------------------------------------
3rdparty/libprocess/include/process/internal.hpp <https://reviews.apache.org/r/24563/#comment88453> for #ifdef blocks, that's how we align: { while (!...) { #if defined(...) || defined(...) asm volatile ... #else ... #endif } } 3rdparty/libprocess/include/process/internal.hpp <https://reviews.apache.org/r/24563/#comment88454> Do all the other arch have "nop" instruction? 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/24563/#comment88455> Ditto. - Jie Yu On Aug. 13, 2014, 7:30 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24563/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 7:30 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu. > > > Bugs: MESOS-1693 > https://issues.apache.org/jira/browse/MESOS-1693 > > > Repository: mesos-git > > > Description > ------- > > Enable building against non-x86 arch, namely arm builders on Fedora. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/internal.hpp 9f478ec > 3rdparty/libprocess/src/process.cpp 14cf317 > configure.ac 8fb0a3a > > Diff: https://reviews.apache.org/r/24563/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
