----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50614 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/internal.hpp <https://reviews.apache.org/r/24563/#comment88482> I would sugguest remove the "nop" here (this is a spin lock anyway and nop is not available on all other archs). #if defined(__i386__) || defined(__x86_64__) asm volatile ("pause") #endif 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/24563/#comment88483> Ditto. - Jie Yu On Aug. 14, 2014, 6:16 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24563/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 6:16 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Jie Yu. > > > Bugs: MESOS-1693 > https://issues.apache.org/jira/browse/MESOS-1693 > > > Repository: mesos-git > > > Description > ------- > > Enable building against non-x86 arch, namely arm builders on Fedora. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/internal.hpp 9f478ec > 3rdparty/libprocess/src/process.cpp c2bee98 > configure.ac 321f09d > > Diff: https://reviews.apache.org/r/24563/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
