----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50719 -----------------------------------------------------------
Thanks for all the help guys! & That is an epic configure line ;-) We need to be careful here, b/c even if they can build, their runtime will need to overload LD_LIBRARY_PATH to point to all the separte locations, and make sure that doesn't muck with other applications. (recommend chroots where possible.) 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/24734/#comment88581> Don't we need LD_FLAGS here, as Vinod mentioned. 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/24734/#comment88582> Switching this check will cause linkage failure on the tests for pure --disable-bundled. It will not affect --prefix installations so I would not change this one, it's a distribution only constraint at this point. configure.ac <https://reviews.apache.org/r/24734/#comment88583> This needs to be here or else the includes fail on distributions. - Timothy St. Clair On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24734/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 6:36 a.m.) > > > Review request for mesos, Timothy St. Clair and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Merged the fix in https://reviews.apache.org/r/24714/ > > Fixed a few other issues. > > Also, did a few consistency/style fix. > > > Diffs > ----- > > 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 > configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c > > Diff: https://reviews.apache.org/r/24734/diff/ > > > Testing > ------- > > On my mac: > > CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure > --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled > --with-leveldb=/opt/twitter --with-glog=/opt/twitter > --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 > --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 > --with-libev=/opt/twitter --with-picojson=/tmp/picojson > --with-http-parser=/tmp/http-parser > > > Thanks, > > Jie Yu > >
