----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ -----------------------------------------------------------
(Updated Aug. 15, 2014, 5:12 p.m.) Review request for mesos, Timothy St. Clair and Vinod Kone. Changes ------- Tim's comments. Tested on Linux with default ./configure. Repository: mesos-git Description ------- Merged the fix in https://reviews.apache.org/r/24714/ Fixed a few other issues. Also, did a few consistency/style fix. Diffs (updated) ----- 3rdparty/libprocess/configure.ac f552e60cbac460a488bf1cd36ddd1e1a54190634 configure.ac 30a7e267dac025270bb69b9ae498cbb8b3f0392c src/tests/group_tests.cpp b265bcba3bfc46e80323ba49cb9193457b36d28c src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f src/tests/zookeeper_tests.cpp 85886199e4d8872af9d944e0f26377b9d85a8c12 src/zookeeper/authentication.hpp 7b6b767b1451bb361c0c26675b642a072f6e5103 src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b Diff: https://reviews.apache.org/r/24734/diff/ Testing ------- On my mac: CC=gcc-4.8 CXX=g++-4.8 ../../../mesos/configure --prefix=/Users/jyu/workspace/mesos-dist/default --disable-bundled --with-leveldb=/opt/twitter --with-glog=/opt/twitter --with-zookeeper=/tmp/zookeeper/3.4.6 --with-protobuf=/tmp/protobuf/2.5.0 --disable-python --with-gmock=/tmp/gmock/gmock-1.7.0 --with-libev=/opt/twitter --with-picojson=/tmp/picojson --with-http-parser=/tmp/http-parser Thanks, Jie Yu
