----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24916/#review51152 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24916/#comment89186> If the image is: ``` my.registry.com:12345/myimage ``` my understanding is that we should append `:latest` to the end, right? - Jie Yu On Aug. 20, 2014, 11:45 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24916/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1724 > https://issues.apache.org/jira/browse/MESOS-1724 > > > Repository: mesos-git > > > Description > ------- > > Allow multiple colons for docker image > > > Diffs > ----- > > src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa > > Diff: https://reviews.apache.org/r/24916/diff/ > > > Testing > ------- > > make check. > Also tested with a local registry server and running multiple colons in the > image name. > > > Thanks, > > Timothy Chen > >
