----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24916/#review51193 -----------------------------------------------------------
Ship it! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24916/#comment89225> Move the comments above "strings::split". Also, we usually do not use const ref for temp variables. // comments here // comments here vector<strings> parts = strings::split(...); if (strings::contains(parts.back(), ":")) { ... } else { ... } - Jie Yu On Aug. 21, 2014, 12:41 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24916/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 12:41 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-1724 > https://issues.apache.org/jira/browse/MESOS-1724 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/24916 > > > Diffs > ----- > > src/slave/containerizer/docker.cpp e3c29b8aaa36ca7500e608a3aa59633e6a6b8eaa > > Diff: https://reviews.apache.org/r/24916/diff/ > > > Testing > ------- > > make check. > Also tested with a local registry server and running multiple colons in the > image name. > > > Thanks, > > Timothy Chen > >
