----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review51382 -----------------------------------------------------------
Looks mostly good, but I'm a little worried about the first & last lines of files. Doubtful that they would have useful comments, but I'd like us to check them for principle's sake. support/cpplint.py <https://reviews.apache.org/r/23710/#comment89668> url, path, or parameter. support/cpplint.py <https://reviews.apache.org/r/23710/#comment89666> Why 'continue' on first and last line? If you skip this early, you'll never set "previous_line = line" to catch punctuation errors in comments on these lines? support/cpplint.py <https://reviews.apache.org/r/23710/#comment89664> s/i/i-1/? support/cpplint.py <https://reviews.apache.org/r/23710/#comment89665> ". \n" should be ".\n" (same for line 1559) support/mesos-style.py <https://reviews.apache.org/r/23710/#comment89661> Can you alphabetize these while you're in there? - Adam B On Aug. 19, 2014, 5:36 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23710/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 5:36 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/23710 > > > Diffs > ----- > > support/cpplint.patch 1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0 > support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b > support/mesos-style.py d24cb11adc06bc0ebaaa206301616c8b597f09e8 > > Diff: https://reviews.apache.org/r/23710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
