> On Aug. 25, 2014, 8:01 a.m., Adam B wrote: > > support/cpplint.py, line 1540 > > <https://reviews.apache.org/r/23710/diff/2/?file=664933#file664933line1540> > > > > Why 'continue' on first and last line? If you skip this early, you'll > > never set "previous_line = line" to catch punctuation errors in comments on > > these lines?
I need to skip the first and last line because ProcessFileData in cpplint.py adds a extra line in the beginning and in the end for line numbers. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review51382 ----------------------------------------------------------- On Aug. 20, 2014, 12:36 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23710/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 12:36 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/23710 > > > Diffs > ----- > > support/cpplint.patch 1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0 > support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b > support/mesos-style.py d24cb11adc06bc0ebaaa206301616c8b597f09e8 > > Diff: https://reviews.apache.org/r/23710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
