----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51669 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/blkio.hpp <https://reviews.apache.org/r/25105/#comment90184> End your comment with a period. src/slave/containerizer/isolators/cgroups/blkio.hpp <https://reviews.apache.org/r/25105/#comment90185> We typically use single line comment for TODOs. // TODO(preilly): src/slave/containerizer/isolators/cgroups/blkio.hpp <https://reviews.apache.org/r/25105/#comment90186> ditto src/slave/containerizer/isolators/cgroups/blkio.hpp <https://reviews.apache.org/r/25105/#comment90187> Single line comments. src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90189> These two lines can become a single line since it fits 80 char width. src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90190> We never throw exceptions in Mesos code (so let's not make this the first). Return Failure("TODO: Implement") for the same intention. However, I think instead of throwing an error you probably want to just return Nothing() and have a TODO comment. src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90192> ditto. src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90193> ditto src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90194> ditto src/slave/containerizer/isolators/cgroups/blkio.cpp <https://reviews.apache.org/r/25105/#comment90195> Not used? - Timothy Chen On Aug. 27, 2014, 5:59 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25105/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 5:59 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-350 > https://issues.apache.org/jira/browse/MESOS-350 > > > Repository: mesos-git > > > Description > ------- > > Currently there is no disk isolation in place and this affects an executor to > be starved of disk when another disk heavy operation such as copying a multi > gigabyte file is being performed by another executor. > > > Diffs > ----- > > include/mesos/mesos.proto dea51f9 > src/Makefile.am 40b9f6b > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 5116b14 > > Diff: https://reviews.apache.org/r/25105/diff/ > > > Testing > ------- > > In progress. > > > Thanks, > > Patrick Reilly > >
