> On Aug. 27, 2014, 11:32 a.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 440-441 > > <https://reviews.apache.org/r/25105/diff/1/?file=670315#file670315line440> > > > > Let's use put the "units" at the end. Also, we can pull out read vs > > write: > > > > disk_read_total_iops > > disk_write_total_iops > > disk_read_total_bytes > > disk_write_total_bytes > > > > I like that the 'disk_' prefix matches the current resource name > > ("disk"), but I wonder if we want to use 'blk_' as the prefix instead, > > especially if we want to introduce new "disk" specific resources.
We've got (or may have) multiple types of "disk" storage, these come to mind: 1) A directory on a shared filesystem. 2) A dedicated filesystem mounted somewhere in a container. 3) A raw block device exposed to the container. I second [~benhindman] that these IO statistics should keep the blk prefix; the statistics and throttling tunables are actually block device specific so I think we should preserve that particular naming while other disk types are worked on. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 ----------------------------------------------------------- On Aug. 27, 2014, 11:50 a.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25105/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 11:50 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-350 > https://issues.apache.org/jira/browse/MESOS-350 > > > Repository: mesos-git > > > Description > ------- > > Currently there is no disk isolation in place and this affects an executor to > be starved of disk when another disk heavy operation such as copying a multi > gigabyte file is being performed by another executor. > > > Diffs > ----- > > include/mesos/mesos.proto dea51f9 > src/Makefile.am 40b9f6b > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 5116b14 > > Diff: https://reviews.apache.org/r/25105/diff/ > > > Testing > ------- > > In progress. > > > Thanks, > > Patrick Reilly > >
