> On Aug. 27, 2014, 8:29 p.m., Timothy Chen wrote: > > src/master/master.hpp, line 1169 > > <https://reviews.apache.org/r/25111/diff/2/?file=670389#file670389line1169> > > > > I don't think you need a bool either. > > It should either succeed or not, and when it doesn't you throw an error > > anyways (doesn't contain info.id). > > > > So I think it should be a Try<Nothing> > > Cody Maloney wrote: > We have to match the protoype of the virtual function of Operation in > registrar.h here. The bool return in the general case is used by the > registrar currently.
Unless, I'm missing something about "Try<Nothing>" I think we need to keep it this way? - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51687 ----------------------------------------------------------- On Aug. 27, 2014, 9:28 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25111/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 9:28 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos-git > > > Description > ------- > > Add basic stub for dynamic slave attributes > > > Diffs > ----- > > src/common/attributes.hpp 0a043d5 > src/common/attributes.cpp aab114e > src/master/master.hpp c9f989a > src/master/master.cpp 2508b38 > src/slave/slave.hpp 9d4607e > src/slave/slave.cpp 5c76dd1 > > Diff: https://reviews.apache.org/r/25111/diff/ > > > Testing > ------- > > This is currently a work in progress, (WIP) > > > Thanks, > > Patrick Reilly > >
