----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51791 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/25111/#comment90398> I appreciate the sentiment here. However, both resources and attributes (although more attributes) could indicate the presence of an undesirable trait, which the framework could use to *not* schedule a task to this slave. IE: attribute "super_secret_network_access:true" for slaves that have access to the super secret network stuff. I believe that at the very least, a change in attributes would end up requiring a reconcillication via frameworks. A reduction in resources possibly through negative offers, and other changes in offers through a revocation of any held offers. At this point, allowing attribute changes (add, remove, modify), is likely ok, with the express documentation that remidiation (killing relevant tasks, etc) would need to occur outside the Mesosphere. The modification of resources should likely be plumbed through to at least revoke outstanding offers, and possibly be plumbed into negative offers and the maintenance bits when they land. - Tobias Weingartner On Aug. 28, 2014, 4:42 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25111/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 4:42 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos-git > > > Description > ------- > > Add basic stub for dynamic slave attributes > > > Diffs > ----- > > src/common/attributes.hpp 0a043d5 > src/common/attributes.cpp aab114e > src/master/master.hpp c9f989a > src/master/master.cpp 2508b38 > src/slave/slave.hpp 9d4607e > src/slave/slave.cpp 5c76dd1 > > Diff: https://reviews.apache.org/r/25111/diff/ > > > Testing > ------- > > This is currently a work in progress, (WIP) > > > Thanks, > > Patrick Reilly > >
