> On Sept. 5, 2014, 9 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp, line 21 > > <https://reviews.apache.org/r/25191/diff/1/?file=672334#file672334line21> > > > > can we use __builtin_unreachable instead? > > > > we should probably check for it (__has_builtin(__builtin_unreachable)).
The compiler intrinsic just acts as a hint to the compiler allowing it to suppress some erroneous warnings as well as better optimize the code, so it doesn't really do the same thing. I think the message is useful for us for debugging / dev / recovering from error. In the case of `__builtin_unreachable` the behavior just becomes undefined / the compiler is free to make the code do absolutely anything it wants (Including if the point is reached execute arbitrary other code from the executable). Could you commit this group of three patches (25191, 25192, 25192)? - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25191/#review52506 ----------------------------------------------------------- On Aug. 29, 2014, 5:53 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25191/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 5:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Dominic Hamon. > > > Bugs: MESOS-1744 > https://issues.apache.org/jira/browse/MESOS-1744 > > > Repository: mesos-git > > > Description > ------- > > Use compiler intrinsics for unreachable, exit, and abort > Makes the functions not need to pretend to return something while > still silencing the compiler warnings. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feea > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 > 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 > > Diff: https://reviews.apache.org/r/25191/diff/ > > > Testing > ------- > > Make check runs. > > > Thanks, > > Patrick Reilly > >
