----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25191/#review54593 -----------------------------------------------------------
Ship it! The whole chain looks good to me, can you reach out to Dominic to get the chain committed for you? 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp <https://reviews.apache.org/r/25191/#comment94774> Once you commit this, no one will know about the multi message version you're referring to ;) I would avoid the TODO altogether and we'll extend _Abort when the need arises. - Ben Mahler On Sept. 25, 2014, 7:34 p.m., Patrick Reilly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25191/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 7:34 p.m.) > > > Review request for mesos, Ben Mahler and Dominic Hamon. > > > Bugs: MESOS-1744 > https://issues.apache.org/jira/browse/MESOS-1744 > > > Repository: mesos-git > > > Description > ------- > > Use compiler intrinsics for unreachable, exit, and abort > Makes the functions not need to pretend to return something while > still silencing the compiler warnings. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp f20feea > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp aaccbb4 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5bbf829 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 > 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 > > Diff: https://reviews.apache.org/r/25191/diff/ > > > Testing > ------- > > Make check runs. > > > Thanks, > > Patrick Reilly > >
